Fix release automation #3426
Merged
Fix release automation #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should also delete this file since (a) it doesn't seem to be used anymore and (b) will be confusing (it currently hasn't been touched in 3 years and has "0.19.0" in it) https://github.com/operator-framework/operator-lifecycle-manager/blob/master/OLM_VERSION |
|
@jmazzitelli I agree with you. I'm planning to look into it, but will probably do that in a separate PR. |
kevinrizza
previously approved these changes
Oct 31, 2024
|
/hold Need to fix the release job for non-tag scenarios: |
openshift-ci
bot
added
the
do-not-merge/hold
Signed-off-by: Mikalai Radchuk <[email protected]>
m1kola
force-pushed
the
fix_release_automation
branch
from
ae23339
to
3c385f6
Compare
m1kola
commented
Oct 31, 2024
| @@ -60,7 +59,8 @@ jobs: | |||
| PKG: github.com/operator-framework/operator-lifecycle-manager | |||
|
|
|||
| - name: Generate quickstart release manifests | |||
| run: make release ver=${{ env.IMAGE_TAG }} IMAGE_REPO=quay.io/operator-framework/olm | |||
| if: startsWith(github.ref, 'refs/tags') | |||
There was a problem hiding this comment.
Adding this condition back (was removed in #3293). This step pulls an image and we don't have an image when running against anything other than a tag.
|
/unhold Should be good now |
openshift-ci
bot
removed
the
do-not-merge/hold
grokspawn
approved these changes
Oct 31, 2024
Merged
via the queue into
operator-framework:master
with commit Oct 31, 2024
5a01f50
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Our release automation is broken after refactoring in #3280: we are no longer passing a real version number from the release workflow.
Fixes #3419
Architectural changes:
None
Testing remarks:
Need to create a new tag to trigger the workflow
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issue